Skip to content

Conversation

@appleboy
Copy link
Member

See: nsqio/nsq#729 (comment)

Signed-off-by: Bo-Yi Wu [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #15 (01ad7b6) into main (d79fb34) will increase coverage by 0.18%.
The diff coverage is 80.90%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   85.00%   85.18%   +0.18%     
==========================================
  Files           2        2              
  Lines         180      189       +9     
==========================================
+ Hits          153      161       +8     
+ Misses         21       20       -1     
- Partials        6        8       +2     
Flag Coverage Δ
go-1.13 ?
go-1.14 ?
go-1.15 ?
go-1.16 ?
go-1.17 85.18% <80.90%> (+1.85%) ⬆️
go-1.18 85.18% <80.90%> (?)
ubuntu-latest 85.18% <80.90%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nsq.go 80.41% <73.75%> (-2.16%) ⬇️
options.go 100.00% <100.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f98429...01ad7b6. Read the comment docs.

@appleboy appleboy merged commit 5cee079 into main Apr 20, 2022
@appleboy appleboy deleted the bugs branch April 20, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants