Skip to content

tree_blob: add tests #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2020
Merged

tree_blob: add tests #58

merged 3 commits into from
Mar 31, 2020

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Mar 31, 2020

Add tests for #57

bharatnc and others added 3 commits March 31, 2020 08:40
This PR adds an `or` conditional to return blob content if a file is an
executable (entry mode 0100755). Prior to this `Blob` func only returned
file contents if a file was of type blob (entry mode 010644). This in a
resulted error to be returned for certain files that were for instance
bash scripts which had the executable mode bit set.
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #58 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files          24       24           
  Lines        1998     1998           
=======================================
  Hits         1670     1670           
  Misses        236      236           
  Partials       92       92           

@unknwon unknwon merged commit cf0a6d7 into master Mar 31, 2020
@unknwon unknwon deleted the bharat/fix-blob-exec branch March 31, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants