tree_blob: return blob contents for blob and exec (#56) #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an `or` conditional to return blob content if a file is an executable (entry mode 0100755). Prior to this `Blob` func only returned file contents if a file was of type blob (entry mode 010644). This in a resulted error to be returned for certain files that were for instance bash scripts which had the executable mode bit set.
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 24 24
Lines 1998 1998
=======================================
Hits 1670 1670
Misses 236 236
Partials 92 92
|
|
Thank you! |
unknwon
changed the title
This was referenced Mar 31, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
orconditional to return blob content if a file is anexecutable (entry mode 0100755). Prior to this
Blobfunc only returnedfile contents if a file was of type blob (entry mode 010644). This in a
resulted error to be returned for certain files that were for instance
bash scripts which had the executable mode bit set.