-
Notifications
You must be signed in to change notification settings - Fork 14
chore(deps): Upgrade shamaton/msgpack from v2.4.0 to v3.0.0 #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @shamaton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine but significant dependency upgrade, moving the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly upgrades the shamaton/msgpack dependency from v2.4.0 to v3.0.0. The changes to go.mod, go.sum, and the import path in msgpack_test.go are appropriate for a major version bump. However, a review of the test file revealed a pre-existing issue that impacts the validation of this upgrade, which is detailed in a specific comment.
| "testing" | ||
|
|
||
| msgpack "github.com/shamaton/msgpack/v2" | ||
| msgpack "github.com/shamaton/msgpack/v3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import path update is correct for the new major version. However, it's critical to ensure that the tests are validating this upgrade. The Test_MsgpackEncoder test in this file has a typo and uses an undefined sampleStructure type instead of sampleMsgPackStructure. This means the test is not running and can't verify the behavior of the new dependency version. Please fix the test to ensure the upgrade is safe and properly verified.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 12 12
Lines 939 939
=======================================
Hits 796 796
Misses 124 124
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
shamaton/msgpackdependency from v2.4.0 to v3.0.0git.colasdn.top/shamaton/msgpack/v2tov3in test filego.modandgo.sumwith new version referencesChanges
v2.4.0tov3.0.0v3module pathRelates