Saving custom resources using the ResourceSaver.FLAG_BUNDLE_RESOURCES flag causes crash on load.

[DaGamingWolf]

Godot version

4.0 dev (106b680) 4.0 dev (432b25d)

System information

windows 10

Issue description

it appears loading a custom resource using ResourceLoader.load() on a file saved with the ResourceSaver.FLAG_BUNDLE_RESOURCES can result in a failure to load the file and an error "<custom_class> hides a global script class."

Steps to reproduce

create a custom Resource, save it with the ResourceSaver.FLAG_BUNDLE_RESOURCES flag, then use ResourceSaver.load()

Minimal reproduction project

Minimal reproducable project.zip

[DaGamingWolf]

The mrp continues to show an error on Godot 4.0 Beta 1 dev (22a09fef5)

[aaronfranke]

Please re-test in the latest master or a recent beta. PR #71142 has likely fixed this issue.

[nezvers]

Godot 4 RC2

Saving a resource with an Array[CollectableResource] of resources with a class_name CollectableResource:
ResourceSaver.save(self, get_filename(), ResourceSaver.FLAG_BUNDLE_RESOURCES)
Loading:
var data:SaveResource = ResourceLoader.load(get_filename(), "SaveResource",ResourceLoader.CACHE_MODE_REPLACE)

Got:
Parser Error: Class "CollectableResource" hides a global script class

Dunno if that's the correct way to save nested resources, but that's the error I run into.

[nezvers]

I created a little playground project.
Nested Resource Saving.zip
res://Resources/SaveGame.tres is the master resource with save/load flag options.
On saving the .tres file content is displayed in a TextEdit.
When FLAG_BUNDLE_RESOURCES is selected it embeds the script of nested resources (with class_name) and upon loading it triggers the bug.
Any other option refers to the array of classes like this:
resources = Array[Resource("res://Resources/CollectibleResource.gd")]([ExtResource("1_avxuu"), ExtResource("2_6my64"), ExtResource("3_oe2tv")])
But also they all are saved the same as without flags, is it supposed to be like that?
FLAG_BUNDLE_RESOURCES is the only one that packs actual values of nested resources.

[DaGamingWolf]

Please re-test in the latest master or a recent beta. PR #71142 has likely fixed this issue.

retested in Godot 4 RC4, The issue is still present. The project still crashes on load, and it appears to be a namespace error of some sort. It's like Godot is saving the class name of the nested resource, then when it loads the resource it becomes incapable of recognizing that the nested resource is an instance of the class registered in godot via class_name, and thus throws an error. That'd be my guess without delving into the editor source code.

the problem pops up when var mrpresource = ResourceLoader.load(file_path) is run, so i'd look into the aspects of the ResourceLoader.load() function that are responsible for checking for namespace conflicts and processing the class of the saved resource.

[SaracenOne]

I'm somewhat curious whether this is technically a bug or not. It's been established it seems that the issue is that FLAG_BUNDLE_RESOURCES is bundling an embedded copy of the NodeData script, which is subsequently creating a naming conflict with the existing NodeData script. It's somewhat nuanced, a script is technically a resource, and it is technically bundling it, along with an error due to the fact the conflicting class_names are not allowed. I think this issue might be difficult to establish a quick fix for and should possibly be punted to allow for broader discussion of what is considered correct behaviour here (should the bundled resource flag simply not bundle scripts with class_name definitions, should this apply to all scripts, ect.?)