Shorten #[init(default = ...)] to #[init(val = ...)]
#844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-844 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ColinWttt
added a commit
to ColinWttt/book
that referenced
this pull request
Feb 2, 2025
The attribute key #[init(val = ...)] replaces #[init(default = ...)]. More information on godot-rust/gdext#844
Bromeon
pushed a commit
to godot-rust/book
that referenced
this pull request
Feb 2, 2025
#73) The attribute key #[init(val = ...)] replaces #[init(default = ...)]. More information on godot-rust/gdext#844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent addition of
#[init(node = ...)]syntax forOnReadynode paths (#807), we now have multiple possible keys for the#[init]attribute.Since "value" is a better differentiator to "node" and possibly other future additions, this is now renamed.
valalso makes the syntax reasonably short, being the most common occurrence. "Default" is a bad name because evennoderepresents a default value, it just expands to a more complex expression. The commonality is that everything used as a field initializer insideinit(), which is expressed by#[init]already.The old syntax has been deprecated and will remain working throughout v0.2. A warning is emitted if it is used.