Skip to content

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Mar 7, 2023

  • Fix crash when converting Variant::nil() to Gd<T>
  • Implement Eq for Gd<T>

Fixes #155.
bors r+

@Bromeon Bromeon added bug feature Adds functionality to the library c: core Core components labels Mar 7, 2023
bors bot added a commit that referenced this pull request Mar 7, 2023
157: `Gd::eq()` + fix `Gd::from_variant(nil)` r=Bromeon a=Bromeon

* Fix crash when converting `Variant::nil()` to `Gd<T>`
* Implement `Eq` for `Gd<T>`

Fixes #155.
bors r+

Co-authored-by: Jan Haller <[email protected]>
@Bromeon Bromeon force-pushed the qol/object-conversions branch from 0e3d2d6 to ed7f30d Compare March 7, 2023 23:16
@bors
Copy link
Contributor

bors bot commented Mar 7, 2023

Canceled.

@Bromeon
Copy link
Member Author

Bromeon commented Mar 7, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 7, 2023

Build succeeded:

@bors bors bot merged commit c169522 into master Mar 7, 2023
@bors bors bot deleted the qol/object-conversions branch March 7, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug c: core Core components feature Adds functionality to the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gd::from_variant(&Variant::nil()) causes crash

1 participant