added key normalizing #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asilvas
suggested changes
Jul 3, 2018
| getBackup(backup, function (backup) { | ||
| rl.write(': converting...'); | ||
| instance.convert({ privateKeyPath: privateKeyPath, backup: backup === 'true' }); | ||
| instance.convert({ privateKeyPath: privateKeyPath, backup: backup === 'true', normalizeKey: (normalizeKey === 'true' || instance.config._.normalizeKey) }); |
There was a problem hiding this comment.
To keep things simple I'd suggest making this default to enabled, and we can bump major version.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most applications use client certificates to encrypt/decrypt configuration, however sometimes the certificate contains
crlfline endings and in other cases has justlfline endings. This change enables the user to strip whitespace from the key before encrypting/decrypting. This change maintains backward compatibility to notnormalizethe key. To update the configuration, runconvert {key} true trueto convert the encrypted data using normalized keys and backup the original values.