Fix streaming Reader race condition #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There was a race condition between creating a `streaming.Reader` with `NewReader` and calling its `Subscribe` where events could be consumed before there is any channel to send them to. - To fix this, the default behavior is now to only start the reader's `read` goroutine when `Subscribe` is called after it has inserted a channel that will receive events. - Alternatively, there is now an option `WithReaderStartExplicitly` which will only start the `read` goroutine when the new `Start` is called allowing multiple calls to `Subscribe` before receiving events.
|
Thank you, that makes sense. I wonder if we need the explicit start option - can we do without? |
I think we can leave it out, I'll remove it. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streaming.ReaderwithNewReaderand calling itsSubscribewhere events could be consumed before there is any channel to send them to.readgoroutine whenSubscribeis called after it has inserted a channel that will receive events.WithReaderStartExplicitlywhich will only start thereadgoroutine when the newStartis called allowing multiple calls toSubscribebefore receiving events.