Support removal of watchers from Zookeeper client. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the application layer to stop watching over the channel provided by the Watch APIs and use these APIs to clean up the "connection.watchers" map. The channels that are no longer watched upon will also be garbage collected with this change. The expectation is that the application can use context with cancellation along with the channel returned by the Watch APIs and call these when the context is cancelled. Or the application can choose to call them independently as well. These functions can also be used to support the removeWatches API that were added to Zookeeper 3.5.0 and above by actually making a call to Zookeeper whenever needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the application layer to stop watching over the channel provided by the Watch APIs and use these APIs to clean up the "connection.watchers" map. Channels that are no longer watched upon will also be garbage collected with this change.
The expectation is that the application can use context with cancellation along with the channel returned by the Watch APIs and call these APIs when the context is cancelled. The application can choose to call them independently as well.
These functions can also be used to support the removeWatches API that were added to Zookeeper 3.5.0 and above by actually making a call to Zookeeper whenever needed.