Skip to content

Conversation

Syfaro
Copy link
Member

@Syfaro Syfaro commented Nov 5, 2020

Closes #390. Would love to get feedback on if I've covered all of the changes correctly!

@Syfaro Syfaro added the telegram update Telegram changed something label Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #392 (fcf56ff) into develop (366879b) will decrease coverage by 0.42%.
The diff coverage is 44.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #392      +/-   ##
===========================================
- Coverage    49.88%   49.45%   -0.43%     
===========================================
  Files            7        7              
  Lines         1287     1379      +92     
===========================================
+ Hits           642      682      +40     
- Misses         609      653      +44     
- Partials        36       44       +8     
Impacted Files Coverage Δ
types.go 77.35% <ø> (ø)
configs.go 39.77% <42.16%> (-0.10%) ⬇️
bot.go 43.09% <55.55%> (+0.38%) ⬆️
helpers.go 60.40% <66.66%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366879b...3b5c8a9. Read the comment docs.

@Syfaro Syfaro linked an issue Nov 6, 2020 that may be closed by this pull request
32 tasks
@tjhorner tjhorner self-requested a review November 6, 2020 06:50
@Syfaro Syfaro changed the title Updates for Bot API 5.0 Updates for Bot API 5.0 and 5.1 Mar 9, 2021
Copy link
Collaborator

@tjhorner tjhorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, it is currently impossible to receive the chat_member update via getUpdates, since it's required to pass that into the allowed_updates parameter to receive them. But from what I can see, it's not currently possible to set that parameter:

telegram-bot-api/configs.go

Lines 889 to 894 in 24d4f79

// UpdateConfig contains information about a GetUpdates request.
type UpdateConfig struct {
Offset int
Limit int
Timeout int
}

We should add this parameter in, then add constants for each of the valid update types.

@Syfaro Syfaro merged commit d10c681 into develop Mar 10, 2021
@Syfaro Syfaro deleted the bot-api-5.0 branch March 10, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

telegram update Telegram changed something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot API 5.0

2 participants