-
-
Notifications
You must be signed in to change notification settings - Fork 746
feat: add failfast support for parallel tasks #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add failfast support for parallel tasks #2307
Conversation
Looking forward to seeing how tests go here! @elvism-lullabot is this defining "fail fast" backwards? To me, |
I updated the code so that the failfast behavior matches the PR description and desired logic. |
Really excited for this. I'm not a maintainer, but I wonder if it would make sense to make |
I have tested these changes and they seem to work as described. Excited for this one to be merged! |
Implement new
failfast
behavior to terminate the parent task immediately when any child task fails.This replaces the previous default behavior, where he execution will stop as soon as any task fails.
New default behavior
By default, when running tasks, the execution of child tasks continues even if one fails.
Restoring Previous Behavior
To restore the previous behavior, you can explicitly set
failfast: true
or with the flag--failfast
.Example
With this configuration, if
task-a
fails early, the parent will stop immediately without waiting fortask-b
ortask-c
.