Occasional flaky tests with grouped output.

[trulede]

Description

There is an occasional flaky test result. It seems like the output of task is captured with split lines, that is to say, a partial line is written as one line, and then the rest of that line is written as a subsequent line. This output, when sorted, the causes the goldie check to fail.

For instance, in the following example, the single line "d3\n" seems to be "d3" and "\n". As a result the check fails.

--- FAIL: TestDeps (0.14s)
      executor_test.go:401: Result did not match the golden fixture. Diff is below:
          
          --- Expected
          +++ Actual
          @@ -1,2 +1,2 @@
          -d1
          +
           d11
          @@ -8,3 +8,2 @@
           d23
          -d3
           d31
          @@ -12,2 +11,3 @@
           d33
          +d3d1
           
          
  FAIL
  FAIL	github.com/go-task/task/v3	6.995s

Its possible that the function

task/task_test.go

Line 304 in e72c35f

func PPSortedLines(t *testing.T, b []byte) []byte {

is not processing the output correctly. It may first need to join lines without a trailing '\n' to the following line, and then apply the sorting algorithm. However, this is not proven, and the output "d3d1\n" does seem odd. In theory, with grouped output, such a combination should not be possible, right? Therefore I wonder if the post processing (PPSortedLines()) causes the issue.

I observe this problem most often with the "deps" test:

task/testdata/deps/Taskfile.yml

Line 1 in e72c35f

version: '3'

Version

v3.44.1

Operating system

Ubuntu

Experiments Enabled

No response

Example Taskfile

[trulede]

Possibly related to #1208. So far only occuring with deps ... could this be a data race?