Skip to content

Fix tests with MySQL 5.7.9 #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2016
Merged

Conversation

luizpvas
Copy link
Contributor

@luizpvas luizpvas commented Nov 8, 2015

From MySQL's reference manual:

NO_AUTO_CREATE_USER will be removed in a future MySQL release, at which point its effect will be enabled at all times (GRANT will not create accounts).

This pull request makes all tests pass against MySQL 5.7.9.

I was getting the following error before the changes:

luiz@asus:~/Code/Go/src/github.com/refl/mysql$ go test github.com/refl/mysql
--- FAIL: TestStrict (0.02s)
    driver_test.go:116: Error on Exec CREATE TABLE test (a TINYINT NOT NULL, b CHAR(4)): Warning 3090: Changing sql mode 'NO_AUTO_CREATE_USER' is deprecated. It will be removed in a future release.
--- FAIL: TestSqlInjection (2.30s)
    driver_test.go:116: Error on Exec CREATE TABLE test (v INTEGER): Warning 3090: Changing sql mode 'NO_AUTO_CREATE_USER' is deprecated. It will be removed in a future release.
--- FAIL: TestInsertRetrieveEscapedData (1.71s)
    driver_test.go:116: Error on Exec CREATE TABLE test (v VARCHAR(255)): Warning 3090: Changing sql mode 'NO_AUTO_CREATE_USER' is deprecated. It will be removed in a future release.
FAIL
FAIL    github.com/refl/mysql    43.664s

julienschmidt added a commit that referenced this pull request Jan 6, 2016
Fix tests with MySQL 5.7.9
@julienschmidt julienschmidt merged commit bb006fd into go-sql-driver:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants