-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix appendLengthEncodedInteger for large numbers > 0xffffff #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM |
There was a typo actually, I just amended it. Suddenly realized 7*8 != 54... |
Damn, I didn't catch that... |
And thanks again, good catch! |
@arnehormann Which is pretty big..It will be quite hard to test with SQL statements for these rare cases. We should probably do some unit tests for these single functions? |
Yes, you are right. |
Not roundtrip tests again 😄 |
Roundtrip in this case: |
@julienschmidt @arnehormann tests added. |
LGTM |
Fix appendLengthEncodedInteger for large numbers > 0xffffff
If the value is ≥ (2^24) and < (2^64) it is stored as fe + 8-byte integer.
The current function seems to be ignoring this case xD.