Skip to content

Optimize traversing the DOM when analyzing text content #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize traversing the DOM when analyzing text content #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 1 addition & 136 deletions internal/re2go/grab-article.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 0 additions & 22 deletions internal/re2go/grab-article.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,25 +37,3 @@ func MaybeItsACandidate(input string) bool {
*/
}
}

// Commas as used in Latin, Sindhi, Chinese and various other scripts.
// see: https://en.wikipedia.org/wiki/Comma#Comma_variants
// Original pattern: \u002C|\u060C|\uFE50|\uFE10|\uFE11|\u2E41|\u2E34|\u2E32|\uFF0C
func CountCommas(input string) int {
var count int
var cursor, marker int
input += string(rune(0)) // add terminating null
limit := len(input) - 1 // limit points at the terminating null
_ = marker

for { /*!use:re2c:base_template
re2c:case-insensitive = 1;

commas = [\u002C\u060C\uFE50\uFE10\uFE11\u2E41\u2E34\u2E32\uFF0C];

{commas} { count++; continue }
* { continue }
$ { return count }
*/
}
}
5 changes: 0 additions & 5 deletions internal/re2go/re2go_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,6 @@ func Test_MaybeItsACandidate(t *testing.T) {
assert.False(t, MaybeItsACandidate(`<p class="text">Paragraph text</p>`))
}

func Test_CountCommas(t *testing.T) {
assert.Equal(t, 3, CountCommas("my,name,is,john"))
assert.Equal(t, 9, CountCommas("now,its،a mixed﹐commas︐from︑various⹁place⸴and⸲country，"))
}

func Test_NormalizeSpaces(t *testing.T) {
assert.Equal(t, "some sentence", NormalizeSpaces("some sentence"))
assert.Equal(t, "with tabs", NormalizeSpaces("with \t \ttabs"))
Expand Down
Loading