Skip to content

xrootd/internal/mux: migrate from xrootd/mux #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2018
Merged

xrootd/internal/mux: migrate from xrootd/mux #198

merged 1 commit into from
May 25, 2018

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented May 22, 2018

Fixes #197.

@sbinet sbinet requested a review from EgorMatirov May 22, 2018 15:41
@sbinet
Copy link
Member Author

sbinet commented May 22, 2018

@EgorMatirov I may have to wait for your first client package to go in before applying this one (so merging is easier)

@sbinet
Copy link
Member Author

sbinet commented May 22, 2018

FYI, this was automatically generated with golang.org/x/tools/cmd/gomvpkg:

$> gomvpkg \
 -from go-hep.org/x/hep/xrootd/mux \
 -to   go-hep.org/x/hep/xrootd/internal/mux \
 -vcs_mv_cmd "git mv {{.Src}} {{.Dst}}"

EgorMatirov
EgorMatirov approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@EgorMatirov EgorMatirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!
Yep, let's wait for the client than (I have updated PR already).

@sbinet
Copy link
Member Author

sbinet commented May 25, 2018

@EgorMatirov: can I merge this in? (ie: I don't think it will conflict (too much?) with (a rebased) #195)

@EgorMatirov
Copy link
Contributor

@sbinet yep, sounds good.

@sbinet sbinet merged commit c81c2d3 into master May 25, 2018
@sbinet sbinet deleted the issue-197 branch May 25, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@EgorMatirov EgorMatirov EgorMatirov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbinet @EgorMatirov