Add parameter support for IN (...) #143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1540,7 +1543,9 @@ func maybeExpandNamedQuery(m *DbMap, query string, args []interface{}) (string, | |||
| return arg.MapIndex(reflect.ValueOf(key)) | |||
| }) | |||
| // #84 - ignore time.Time structs here - there may be a cleaner way to do this | |||
| case arg.Kind() == reflect.Struct && !(arg.Type().PkgPath() == "time" && arg.Type().Name() == "Time"): | |||
| case arg.Kind() == reflect.Struct && | |||
| !(arg.Type().PkgPath() == "time" && arg.Type().Name() == "Time") && | |||
There was a problem hiding this comment.
I think doing something like
var (
timeType = reflect.TypeOf(time.Time{})
listType = reflect.TypeOf(List{})
)
func ..
if arg.Type() != timeType && arg.Type() != listType {
..
}could be cleaner
|
Just bumping this, any comments on it? |
|
Hi, I was just wondering if I could get some feedback on this pull request? Thanks in advance! |
| "strings" | ||
| ) | ||
|
|
||
| const ( | ||
| NOT_POSTGRES = -2 |
There was a problem hiding this comment.
Despite being constant, this should be lowerCamel, to avoid exporting it
There was a problem hiding this comment.
this is meant to indicate absence of an index. The builtin string index functions use -1 -- any reason you chose -2 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for expansion of a slice of values if the slice was tagged wrapped with gorp.List{}. It should be noted that for sqlite this only works if '?' are the only used placeholders.