fix ci #9958
fix ci #9958
Conversation
|
@lunny what ci error you want to fix? |
GiteaBot
added
the
lgtm/need 2
|
@bagasme please see errors in CI currently: https://drone.gitea.io/go-gitea/gitea/20122/3/6 |
|
can you update branch ? |
|
ok looks like #9959 did it .. can we close this ? |
|
There is still a hidden error with the mail templates during testing. |
| @@ -237,7 +237,7 @@ func composeIssueCommentMessages(ctx *mailCommentContext, tos []string, fromMent | |||
|
|
|||
| var mailBody bytes.Buffer | |||
|
|
|||
| if err := bodyTemplates.ExecuteTemplate(&mailBody, string(tplName), mailMeta); err != nil { | |||
| if err := bodyTemplates.ExecuteTemplate(&mailBody, string(tplName+"-body"), mailMeta); err != nil { | |||
There was a problem hiding this comment.
This should not be necessary. bodyTemplates already contains templates for bodies only. This would generate names like "issue/new-body", which should not exist (and the function would leave mailBody empty).
It might be a little confusing that the log is written like:
log.Error("ExecuteTemplate [%s]: %v", string(tplName)+"/body", err)
Which suggest there is such thing as "issue/new/body", but in reality the name of the template is "issue/new" (or "issue/default") for both subject and body. The log says +"/body" only so the user knows which part of the template is failing.
Test if this fixed ci