Make archive prefixing configurable with a global setting #9943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
the
type/feature
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Jan 22, 2020
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Jan 22, 2020
GiteaBot
added
lgtm/done
guillep2k
reviewed
Jan 22, 2020
| // CreateArchive create archive content to the target path | ||
| func (c *Commit) CreateArchive(target string, opts CreateArchiveOpts) error { | ||
| if opts.Format.String() == "unknown" { | ||
| return fmt.Errorf("unknown format: %v", opts.Format) |
There was a problem hiding this comment.
@guillep2k this is the line I was referencing.
jolheiser
approved these changes
Jan 22, 2020
|
|
||
| // CreateArchive create archive content to the target path | ||
| func (c *Commit) CreateArchive(target string, opts CreateArchiveOpts) error { | ||
| if opts.Format.String() == "unknown" { |
There was a problem hiding this comment.
Perhaps, if anything, we could add another constant for UNKNOWN and compare to that rather than a string?
There was a problem hiding this comment.
It doesn't really seem worth it - the unknown is only used in that file and in those two places.
guillep2k
approved these changes
Jan 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #9943 +/- ##
=========================================
Coverage ? 42.28%
=========================================
Files ? 608
Lines ? 79411
Branches ? 0
=========================================
Hits ? 33580
Misses ? 41691
Partials ? 4140Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a global setting to default git archive prefixing.
Fix #9903