Explicitly refer to PR in squash-merge commit message in case of external tracker #9844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9844 +/- ##
==========================================
+ Coverage 42.3% 42.31% +<.01%
==========================================
Files 604 604
Lines 79137 79137
==========================================
+ Hits 33479 33486 +7
+ Misses 41529 41524 -5
+ Partials 4129 4127 -2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
guillep2k
approved these changes
Jan 17, 2020
GiteaBot
added
lgtm/need 1
|
@davidsvantesson can you add a infomation to the documentation? |
GiteaBot
added
lgtm/done
zeripath
approved these changes
Jan 17, 2020
davidsvantesson
added a commit
to davidsvantesson/gitea
that referenced
this pull request
Jan 18, 2020
…rnal tracker (go-gitea#9844) * Explicitly refer to PR in squash-merge commit message in case of external tracker * documentation Co-authored-by: zeripath <[email protected]>
lunny
pushed a commit
that referenced
this pull request
Jan 18, 2020
…rnal tracker (#9844) (#9855) * Explicitly refer to PR in squash-merge commit message in case of external tracker * documentation Co-authored-by: zeripath <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid creating a link to external tracker, i.e. use
!instead of#. As I think it would be controversial to change this on all repositories, I only change it for those having external tracker enabled.This is related to changes intoduced by #9116, so could be considered for backporting to 1.11.