Skip to content

Allow assignee on Pull Creation when Issue Unit is deactivated #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
Jan 17, 2020
Merged

Allow assignee on Pull Creation when Issue Unit is deactivated #9836

lunny merged 2 commits into from
Jan 17, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Jan 17, 2020

close #9824

@6543 6543 mentioned this pull request Jan 17, 2020
Closed
7 tasks
@lunny lunny added the type/bug label Jan 17, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 17, 2020
This was referenced Jan 17, 2020
Merged
Merged
@6543 6543 changed the title Fix #9824 | Allow assignee on PR eaven Issue is deactivated Allow assignee on Pull Creation when Issue Unit is deactivated Jan 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2020
@guillep2k
Copy link
Member

guillep2k commented Jan 17, 2020

Unrelated, but there seems to be a problem with the dark mode theme about this:

image

(Only for the create PR page; in the view PR the assignees are displayed correctly).

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@11eb5d1). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9836   +/-   ##
=========================================
  Coverage          ?   42.32%           
=========================================
  Files             ?      604           
  Lines             ?    79126           
  Branches          ?        0           
=========================================
  Hits              ?    33487           
  Misses            ?    41515           
  Partials          ?     4124
Impacted Files Coverage Δ
routers/repo/download.go 39.28% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11eb5d1...0b59fde. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Jan 17, 2020

ready to merge 🚀

@lunny lunny merged commit 2f3a602 into go-gitea:master Jan 17, 2020
@lunny
Copy link
Member

lunny commented Jan 17, 2020

Please send backport

@6543 6543 deleted the fix-pull-assignee branch January 17, 2020 14:38
@6543
Copy link
Member Author

6543 commented Jan 17, 2020

@lunny already done 😅

@lunny lunny added the backport/done All backports for this PR have been created label Jan 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

I cannot assign a user when creating a PR

5 participants

@6543 @guillep2k @codecov-io @lunny @GiteaBot