Fix wrong identify poster on a migrated pull request when submit review #9827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
approved these changes
Jan 17, 2020
GiteaBot
added
the
lgtm/need 1
sapk
reviewed
Jan 17, 2020
| @@ -440,7 +440,7 @@ func (issue *Issue) HashTag() string { | |||
|
|
|||
| // IsPoster returns true if given user by ID is the poster. | |||
| func (issue *Issue) IsPoster(uid int64) bool { | |||
| return issue.PosterID == uid | |||
| return issue.OriginalAuthorID == 0 && issue.PosterID == uid | |||
There was a problem hiding this comment.
Just to confirm from what I have understand when migrating if the user exist OriginalAuthorID is not and set and issue.PosterID is not the doer (like it is by default) but found user ?
There was a problem hiding this comment.
If OriginalAuthorID > 0, PosterID means migrator but not poster id. OriginalAuthorID is an external system id not gitea user id.
Codecov Report
@@ Coverage Diff @@
## master #9827 +/- ##
==========================================
+ Coverage 42.31% 42.32% +0.01%
==========================================
Files 604 604
Lines 79116 79116
==========================================
+ Hits 33479 33488 +9
+ Misses 41516 41505 -11
- Partials 4121 4123 +2
Continue to review full report at Codecov.
|
lafriks
approved these changes
Jan 17, 2020
GiteaBot
added
lgtm/done
|
@lunny please send backports |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 17, 2020
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 17, 2020
sapk
pushed a commit
that referenced
this pull request
Jan 17, 2020
sapk
pushed a commit
that referenced
this pull request
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8959