Skip to content

Fix push-to-create #9772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 16, 2020
Merged

Fix push-to-create #9772

merged 10 commits into from
Jan 16, 2020

Conversation

jolheiser
Copy link
Member

No description provided.

@jolheiser
Fix push-to-create
501d36d 
Signed-off-by: jolheiser <[email protected]>
guillep2k
guillep2k reviewed Jan 14, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2020
6543
6543 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2020
@codecov-io
Copy link

codecov-io commented Jan 14, 2020 •
edited
Loading

Codecov Report

Merging #9772 into master will decrease coverage by 0.13%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9772      +/-   ##
==========================================
- Coverage   42.33%   42.19%   -0.14%     
==========================================
  Files         600      603       +3     
  Lines       78361    78850     +489     
==========================================
+ Hits        33173    33270      +97     
- Misses      41133    41507     +374     
- Partials     4055     4073      +18
Impacted Files Coverage Δ
models/repo.go 46.74% <ø> (ø) ⬆️
services/repository/transfer.go 66.66% <66.66%> (ø) ⬆️
routers/repo/http.go 39.01% <92.85%> (+1.68%) ⬆️
routers/private/hook.go 34.14% <0%> (-9.77%) ⬇️
models/repo_sign.go 36.2% <0%> (-4.18%) ⬇️
modules/repofiles/delete.go 46.93% <0%> (-3.44%) ⬇️
modules/git/command.go 89.56% <0%> (-3.3%) ⬇️
models/pull_sign.go 34.86% <0%> (-3.14%) ⬇️
models/branches.go 40.58% <0%> (-2.95%) ⬇️
services/pull/patch.go 62.89% <0%> (-2.93%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29c824...6de248f. Read the comment docs.

sapk
sapk reviewed Jan 14, 2020
View reviewed changes
@sapk sapk added this to the 1.12.0 milestone Jan 15, 2020
@techknowlogick
Copy link
Member

seems "update branch" is even missing for admins.

@jolheiser
Copy link
Member Author

@techknowlogick Just updated the branch now. I don't even see the option to allow or not allow it anymore, so I have no idea. 😅

@techknowlogick
Copy link
Member

Weird, I'll merge this next so you don't need to get @'d to update it anymore.

@jolheiser
Copy link
Member Author

@techknowlogick Fine with me so long as @sapk doesn't consider his request to be a blocker?

@techknowlogick
Copy link
Member

@jolheiser hmmm... good point. I'll hold off. His request is a good one.

@lunny lunny added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug labels Jan 15, 2020
@jolheiser jolheiser requested a review from sapk January 15, 2020 17:01
zeripath
zeripath suggested changes Jan 15, 2020
View reviewed changes
@jolheiser
Copy link
Member Author

Ping LGTM.

@lunny lunny merged commit 176e7fb into go-gitea:master Jan 16, 2020
jolheiser added a commit to jolheiser/gitea that referenced this pull request Jan 16, 2020
@jolheiser
Fix push-to-create (go-gitea#9772)
0ad37ba 
* Fix push-to-create

Signed-off-by: jolheiser <[email protected]>

* Check URL path and service

Signed-off-by: jolheiser <[email protected]>

* Send dummy payload on receive-pack GET

Signed-off-by: jolheiser <[email protected]>

* The space was actually a NUL byte

Signed-off-by: jolheiser <[email protected]>

* Use real bare repo instead of manufactured payload

Signed-off-by: jolheiser <[email protected]>
@jolheiser jolheiser mentioned this pull request Jan 16, 2020
Merged
@jolheiser jolheiser deleted the push_create_post branch January 16, 2020 02:44
@lafriks lafriks added the backport/done All backports for this PR have been created label Jan 16, 2020
lafriks pushed a commit that referenced this pull request Jan 16, 2020
@jolheiser @zeripath @lafriks
Fix push-to-create (#9772) (#9797)
3521177 
* Fix push-to-create

Signed-off-by: jolheiser <[email protected]>

* Check URL path and service

Signed-off-by: jolheiser <[email protected]>

* Send dummy payload on receive-pack GET

Signed-off-by: jolheiser <[email protected]>

* The space was actually a NUL byte

Signed-off-by: jolheiser <[email protected]>

* Use real bare repo instead of manufactured payload

Signed-off-by: jolheiser <[email protected]>

Co-authored-by: zeripath <[email protected]>
@sapk sapk added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Jan 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@sapk sapk Awaiting requested review from sapk

+2 more reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
10 participants
@jolheiser @codecov-io @techknowlogick @zeripath @sapk @guillep2k @6543 @lunny @lafriks @GiteaBot