Fix milestones page #9770
Merged
Fix milestones page #9770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
GiteaBot
added
the
lgtm/need 1
sapk
approved these changes
Jan 14, 2020
GiteaBot
added
lgtm/done
|
@jolheiser created backport |
|
It seems to always has been multi-select but it feel wrong to hide it. |
|
I simply NOT hide it - to be consistent |
sapk
reviewed
Jan 14, 2020
Thanks? |
Codecov Report
@@ Coverage Diff @@
## master #9770 +/- ##
==========================================
+ Coverage 42.32% 42.32% +<.01%
==========================================
Files 600 600
Lines 78357 78357
==========================================
+ Hits 33165 33168 +3
+ Misses 41136 41134 -2
+ Partials 4056 4055 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9748
In the past (before multi-select) I'm guessing this template check was because the selected repo would be the repo name for all the listed milestones.
If I missed something, please let me know. 😃