Skip to content

[Docs] Grammar Edit on Enabling HTTPS Using Reverse Proxy #9649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2020
Merged

[Docs] Grammar Edit on Enabling HTTPS Using Reverse Proxy #9649

merged 2 commits into from
Jan 8, 2020

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Jan 8, 2020

As per title.

This PR fix grammar errors I made from #9491.

@codecov-io
Copy link

Codecov Report

Merging #9649 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9649      +/-   ##
=========================================
+ Coverage   42.19%   42.2%   +<.01%     
=========================================
  Files         583     583              
  Lines       77234   77234              
=========================================
+ Hits        32590   32594       +4     
+ Misses      40636   40634       -2     
+ Partials     4008    4006       -2
Impacted Files Coverage Δ
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 55.59% <0%> (+0.55%) ⬆️
services/pull/merge.go 53.92% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88d67b...82262ac. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2020
@sapk sapk added the type/docs This PR mainly updates/creates documentation label Jan 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2020
@sapk sapk merged commit 74d6ec6 into go-gitea:master Jan 8, 2020
@sapk sapk added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 8, 2020
@bagasme bagasme deleted the docs/https-reverse-proxy-grammar-edit branch January 13, 2020 12:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bagasme @codecov-io @sapk @6543 @GiteaBot