Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 7, 2020

since #9535 will take it's time ...

a quick fix

how to reproduce the bug:

  1. watch a repo
  2. unwatch a issue of this repo
  3. reload (issue is shown as subscibed - its not) -> if you try again you get a 500 :/

and for the api (witch use this function GetIssueWatchers too) https://github.com/go-gitea/gitea/blob/master/models/issue_watch.go#L116 take kare of it ...

@lunny lunny added the type/bug label Jan 7, 2020
@lunny lunny added this to the 1.11.0 milestone Jan 7, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 7, 2020
@zeripath
Copy link
Contributor

zeripath commented Jan 7, 2020

I'd recommend popping a comment on explaining why this one differs from the other watcher functions and needs to get the negative watchers too.

@zeripath
Copy link
Contributor

zeripath commented Jan 7, 2020

otherwise LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6842d55). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9634   +/-   ##
=========================================
  Coverage          ?   42.22%           
=========================================
  Files             ?      582           
  Lines             ?    77103           
  Branches          ?        0           
=========================================
  Hits              ?    32557           
  Misses            ?    40546           
  Partials          ?     4000

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6842d55...b6e6316. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Jan 7, 2020

ready to merge 🚀

@zeripath zeripath merged commit 9406368 into go-gitea:master Jan 7, 2020
@6543 6543 deleted the fix-issue-unsubscription branch January 7, 2020 15:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants