Skip to content

Conversation

davidsvantesson
Copy link
Contributor

My PRs. I think I will have time to do some reviewing as well 😄.

I have the same username on discord and gitea.com.

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Dec 3, 2019
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions ;)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #9240 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9240      +/-   ##
==========================================
+ Coverage   41.08%   41.09%   +<.01%     
==========================================
  Files         555      555              
  Lines       72393    72393              
==========================================
+ Hits        29745    29747       +2     
+ Misses      38904    38900       -4     
- Partials     3744     3746       +2
Impacted Files Coverage Δ
modules/indexer/indexer.go 44.73% <0%> (-10.53%) ⬇️
modules/migrations/migrate.go 23.78% <0%> (-1.63%) ⬇️
modules/migrations/gitea.go 8.82% <0%> (-0.64%) ⬇️
models/repo.go 47.82% <0%> (-0.06%) ⬇️
models/repo_list.go 74.07% <0%> (+0.92%) ⬆️
models/error.go 33.86% <0%> (+1.18%) ⬆️
modules/task/migrate.go 28.94% <0%> (+3.94%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e459f99...65c892e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2019
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!!

Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome. I restarted the CI that fail for unrelated version.

@sapk sapk merged commit 4256781 into go-gitea:master Dec 3, 2019
@sapk
Copy link
Member

sapk commented Dec 3, 2019

I will let @go-gitea/owners add you on gitea.com and github to maintainer teams and discord.

@davidsvantesson davidsvantesson deleted the patch-1 branch December 3, 2019 13:32
@jolheiser
Copy link
Member

I'm late to this party, but welcome!!

@lunny
Copy link
Member

lunny commented Dec 3, 2019

@davidsvantesson Welcome! @sapk done.

@techknowlogick
Copy link
Member

techknowlogick commented Dec 3, 2019

@davidsvantesson welcome! Do you have a discord user, if so let me know and I can give you the appropriate permissions.

Edit:whoops, I should read what you said above about discord, nvm me.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants