feat: support search bar on star tab of user profile. #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
changed the title
lunny
added
the
type/feature
appleboy
changed the title
|
LGTM |
tboerger
added
the
lgtm/need 1
lunny
requested changes
Feb 13, 2017
| return nil, 0, fmt.Errorf("Repo: %v", err) | ||
| } | ||
|
|
||
| if opts.Starred { |
There was a problem hiding this comment.
Maybe you could see https://github.com/go-gitea/gitea/blob/master/models/repo.go#L2156
lunny
approved these changes
Feb 13, 2017
tboerger
reviewed
Feb 14, 2017
models/repo.go
Outdated
| sess = x. | ||
| Join("INNER", "star", "star.repo_id = repository.id"). | ||
| Where("star.uid = ?", opts.OwnerID). | ||
| And("LOWER(lower_name) LIKE ?", "%"+opts.Keyword+"%") |
There was a problem hiding this comment.
Need lower here? Sounds like it should already be lower
|
I have not tested it but beside the single comment LGTM |
tboerger
added
lgtm/done
Signed-off-by: Bo-Yi Wu <[email protected]>
|
let L-G-T-M work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the repo format of star tab of user profile.
Origin: https://try.gitea.io/appleboy?tab=stars