Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 3, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 3, 2019
@codecov-io
Copy link

codecov-io commented Nov 3, 2019

Codecov Report

Merging #8807 into master will decrease coverage by <.01%.
The diff coverage is 69.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8807      +/-   ##
==========================================
- Coverage   41.23%   41.23%   -0.01%     
==========================================
  Files         543      543              
  Lines       69785    69776       -9     
==========================================
- Hits        28777    28771       -6     
- Misses      37321    37322       +1     
+ Partials     3687     3683       -4
Impacted Files Coverage Δ
modules/notification/base/null.go 65.38% <100%> (+2.88%) ⬆️
modules/notification/notification.go 74.77% <100%> (+1.95%) ⬆️
modules/notification/webhook/webhook.go 39.62% <61.53%> (+1.81%) ⬆️
modules/repofiles/action.go 66.27% <71.42%> (+1.94%) ⬆️
models/repo_indexer.go 66.54% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b8c08...b88dcc7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 4, 2019
@lunny lunny force-pushed the lunny/move_repofile_webhook branch from e99e080 to aadc508 Compare November 5, 2019 11:15
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2019
@lunny lunny merged commit 8a84d82 into go-gitea:master Nov 6, 2019
@lunny lunny deleted the lunny/move_repofile_webhook branch November 6, 2019 06:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants