Skip to content

Improve status table implementation #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2017

Conversation

minecrafter
Copy link
Contributor

This pull request improves the status table implementation in a few ways:

  • Removes defer calls. Using defer to cover reading or modifying a map is superfluous.
  • Change underlying data structure from map[string]bool to a map[string]struct{}, which is more appropriate as this is essentially a thread-safe set.
  • Adds testing.

This would probably only help with large, high-traffic installs
@lunny lunny added this to the 1.1.0 milestone Feb 9, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 9, 2017
@lunny
Copy link
Member

lunny commented Feb 9, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 9, 2017
@appleboy
Copy link
Member

appleboy commented Feb 9, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2017
@lunny lunny merged commit 1da7dd3 into go-gitea:master Feb 9, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants