Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 8, 2019

only wait for #8418 (alreay included in changelog)

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Oct 8, 2019
@techknowlogick techknowlogick added this to the 1.9.4 milestone Oct 8, 2019
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2019
@lafriks
Copy link
Member

lafriks commented Oct 8, 2019

imho we can release without that PR, just need to merge #8425 #8418 first

We ned to revert this then ...

Co-Authored-By: Lauris BH <[email protected]>
@6543
Copy link
Member Author

6543 commented Oct 8, 2019

@lafriks you mean revert last PR ...?

@lafriks
Copy link
Member

lafriks commented Oct 8, 2019

@6543 that is revert PR ( #8425) that needs to be merged

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2019
@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 8, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2019
@lafriks lafriks merged commit 6ab1d5a into go-gitea:release/v1.9 Oct 8, 2019
@6543 6543 deleted the v1.9.4-changelog branch October 8, 2019 19:07
guillep2k pushed a commit to guillep2k/gitea that referenced this pull request Oct 9, 2019
* changelog

* Update CHANGELOG.md

We ned to revert this then ...

Co-Authored-By: Lauris BH <[email protected]>
sapk pushed a commit that referenced this pull request Oct 9, 2019
* changelog

* Update CHANGELOG.md

We ned to revert this then ...

Co-Authored-By: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants