Skip to content

Conversation

guillep2k
Copy link
Member

I keep cutting down the utf8 tests. This time to fix this error:

image

As always, errors occur only from time to time.

@guillep2k
Copy link
Member Author

Connected with this fail: #8349 (comment)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2019
@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #8393 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8393      +/-   ##
=========================================
+ Coverage   41.79%   41.8%   +0.01%     
=========================================
  Files         497     497              
  Lines       65608   65608              
=========================================
+ Hits        27419   27429      +10     
+ Misses      34673   34665       -8     
+ Partials     3516    3514       -2
Impacted Files Coverage Δ
models/repo_indexer.go 70.15% <0%> (+3.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08896cd...097836f. Read the comment docs.

@techknowlogick techknowlogick merged commit 356e1a7 into go-gitea:master Oct 7, 2019
@guillep2k guillep2k deleted the fix-charset-again branch October 16, 2019 00:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants