Extract actions on new pull request from models to pulls service and move code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull #8218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
lafriks
requested changes
Sep 18, 2019
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/move_pr
branch
from
29c184f to
ede6123
Compare
|
@lafriks done. |
lafriks
reviewed
Sep 25, 2019
routers/api/v1/repo/pull.go
Outdated
| @@ -20,6 +20,7 @@ import ( | |||
| api "code.gitea.io/gitea/modules/structs" | |||
| "code.gitea.io/gitea/modules/timeutil" | |||
| milestone_service "code.gitea.io/gitea/services/milestone" | |||
| pull_service "code.gitea.io/gitea/services/pulls" | |||
There was a problem hiding this comment.
import declared with same name as import above:
pull_service "code.gitea.io/gitea/modules/pull"
lafriks
requested changes
Sep 25, 2019
lunny
force-pushed
the
lunny/move_pr
branch
from
ede6123 to
38f9def
Compare
lunny
changed the title
|
@lafriks done and moved |
lunny
force-pushed
the
lunny/move_pr
branch
from
9fb0970 to
1b5e022
Compare
Codecov Report
@@ Coverage Diff @@
## master #8218 +/- ##
==========================================
- Coverage 41.55% 41.54% -0.01%
==========================================
Files 492 493 +1
Lines 65355 65360 +5
==========================================
+ Hits 27155 27157 +2
- Misses 34704 34706 +2
- Partials 3496 3497 +1
Continue to review full report at Codecov.
|
guillep2k
approved these changes
Sep 26, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Sep 26, 2019
GiteaBot
added
lgtm/done
|
make L-G-T-M work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.