Skip to content

[WIP] [Feature] Implement issue reference cross comment #8147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] [Feature] Implement issue reference cross comment #8147

wants to merge 2 commits into from

Conversation

jaqra
Copy link
Contributor

@jaqra jaqra commented Sep 10, 2019

I am trying to add issue reference comment.

Can you tell me your opinions?

Currently gitea adds comment when:

  • New Issue (From Title)
  • New Issue (From Content)
  • Update Issue Title
  • Update Issue Content
  • New Comment
  • Update Comment

But:

  • I think i should add a column for check if comment has already exists

Screenshot_2019-09-11_01-34-58

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@10dfb44). Click here to learn what that means.
The diff coverage is 10.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8147   +/-   ##
=========================================
  Coverage          ?   41.75%           
=========================================
  Files             ?      482           
  Lines             ?    64636           
  Branches          ?        0           
=========================================
  Hits              ?    26990           
  Misses            ?    34172           
  Partials          ?     3474
Impacted Files Coverage Δ
routers/repo/issue.go 35.29% <0%> (ø)
models/issue_comment.go 47.87% <10.16%> (ø)
models/issue.go 49.57% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10dfb44...08a7058. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2019
@jaqra
Copy link
Contributor Author

jaqra commented Sep 11, 2019

Ohh sorry @guillep2k :(

I did not see that #8137 PR. I'm closing this.

@jaqra jaqra closed this Sep 11, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants