Skip to content

Wrap CONTRIBUTING.md text to 80 columns #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2016
Merged

Wrap CONTRIBUTING.md text to 80 columns #81

merged 3 commits into from
Nov 5, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 5, 2016

subject says it all

@strk strk added the type/enhancement An improvement of existing functionality label Nov 5, 2016
tboerger
tboerger reviewed Nov 5, 2016
View reviewed changes
CONTRIBUTING.md

2016-11-04 ~ 2017-12-31 lunny <[email protected]> tboerger <[email protected]> bkcsoft <[email protected]>
2016-11-04 ~ 2017-12-31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a list here?

@tboerger
Copy link
Member

tboerger commented Nov 5, 2016

One NITPICK otherwise LGTM

@codecov-io
Copy link

codecov-io commented Nov 5, 2016 •
edited
Loading

Current coverage is 2.18% (diff: 100%)

Merging #81 into master will not change coverage

@@            master       #81   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17

Powered by Codecov. Last update 92f39da...8e126b2

@strk
Wrap text to 80 columns
2db284e 
Use a list for owners (nitpick response)
@strk
Copy link
Member Author

strk commented Nov 5, 2016

Used a list, rebased to master and squashed

@tboerger
Copy link
Member

tboerger commented Nov 5, 2016

LGTM

@tboerger tboerger added this to the 1.0.0 milestone Nov 5, 2016
@metalmatze
Copy link
Contributor

LGTM

@DblK DblK added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 5, 2016
@strk strk merged commit 9f437eb into go-gitea:master Nov 5, 2016
@strk strk deleted the wrap80 branch November 5, 2016 22:24
@tboerger tboerger removed the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 11, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@lafriks
Add method to allow custom sorting of tree entry list (go-gitea#81)
d7487da 
* Add method to allow custom sorting of tree entry list

* Add tests for git tree entries sorting
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@tboerger tboerger tboerger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@strk @tboerger @codecov-io @metalmatze @DblK