Skip to content

Fix regression in reverse proxy documentation #7634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

Fix regression in reverse proxy documentation #7634

merged 2 commits into from
Jul 26, 2019

Conversation

@mrsdizzie
Copy link
Member

@mrsdizzie mrsdizzie commented Jul 26, 2019

From Apache: AllowEncodedSlashes not allowed in <Proxy> context

Move this out of <Proxy> block

Fixes #7632

I've also moved the #comment to its own line so you can just copy and paste without syntax error

@mrsdizzie
Fix regression in reverse proxy documentation
a57a1ea 
From Apache: AllowEncodedSlashes not allowed in <Proxy> context

Move this out of <Proxy> block

Fixes go-gitea#7632
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 26, 2019
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jul 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2019
@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #7634 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7634      +/-   ##
==========================================
+ Coverage   41.26%   41.28%   +0.01%     
==========================================
  Files         469      469              
  Lines       63716    63716              
==========================================
+ Hits        26295    26304       +9     
+ Misses      33997    33989       -8     
+ Partials     3424     3423       -1
Impacted Files Coverage Δ
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdaf9a5...e8e1d2f. Read the comment docs.

@techknowlogick techknowlogick merged commit 700cd34 into go-gitea:master Jul 26, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reverse proxy documentation regression

5 participants

@mrsdizzie @codecov-io @techknowlogick @zeripath @GiteaBot