Update CONTRIBUTING.md with information about DCO #7397
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |||||
| - [Translation](#translation) | ||||||
| - [Code review](#code-review) | ||||||
| - [Styleguide](#styleguide) | ||||||
| - [Developer Certificate of Origin (DCO)](#developer-certificate-of-origin-dco) | ||||||
| - [Release Cycle](#release-cycle) | ||||||
| - [Maintainers](#maintainers) | ||||||
| - [Owners](#owners) | ||||||
|
|
@@ -77,7 +77,7 @@ Here's how to run the test suite: | |||||
| creates (a default AWS or GCE disk size won't work -- see | ||||||
| [#6243](https://github.com/go-gitea/gitea/issues/6243)). | ||||||
| - Change into the base directory of your copy of the gitea repository, | ||||||
| and run `drone exec --event pull_request`. | ||||||
|
|
||||||
| The drone version, command line, and disk requirements do change over | ||||||
| time (see [#4053](https://github.com/go-gitea/gitea/issues/4053) and | ||||||
|
|
@@ -157,22 +157,21 @@ import ( | |||||
| ) | ||||||
| ``` | ||||||
|
|
||||||
| ## Developer Certificate of Origin (DCO) | ||||||
|
|
||||||
| We consider the act of contributing to the code by submitting a Pull | ||||||
| Request as the "Sign off" or agreement to the certifications and terms | ||||||
| of the [DCO](DCO) and [MIT license](LICENSE). No further action is required. | ||||||
| Additionally you could add a line at the end of your commit message. | ||||||
|
|
||||||
| ``` | ||||||
| Signed-off-by: Joe Smith <[email protected]> | ||||||
| ``` | ||||||
|
|
||||||
| If you set your `user.name` and `user.email` git configs, you can add the | ||||||
| line to the end of your commit automatically with `git commit -s`. | ||||||
|
|
||||||
| We assume in good faith that the information you provide is legally biding. | ||||||
techknowlogick marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| We assume in good faith that the information you provide is legally biding. | |
| We assume in good faith that the information you provide adheres to the [DCO](DCO), and won't request more personal information than provided for contributions. |
Not sure if this change makes sense with the DCO, but also we do allow pseudonyms and we probably aren't assuming they are 100% legally binding (and in many cases as the contributions aren't on a large scale to wonder if they were taken from anywhere else). Also I think with the information above most people who don't mind will do the sign off with legal name as they do now and people who don't want to won't
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is unrelated to this PR, but as it is small rather than open a second PR for just this I have included here. If there is opposition to including this line in this PR please comment here and I will open a second PR for this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is an open issue related to that. I will look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was closed by an other PR but this one complete it #7350