Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 3, 2019

As title.

@lunny lunny added this to the 1.9.0 milestone Jul 3, 2019
@lunny lunny requested a review from techknowlogick July 3, 2019 03:18
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 3, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #7346 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7346      +/-   ##
==========================================
- Coverage   41.25%   41.25%   -0.01%     
==========================================
  Files         467      467              
  Lines       63291    63291              
==========================================
- Hits        26112    26108       -4     
- Misses      33762    33767       +5     
+ Partials     3417     3416       -1
Impacted Files Coverage Δ
routers/api/v1/api.go 71.36% <100%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ec7b8...06f696b. Read the comment docs.

@zeripath zeripath merged commit b5aa7f7 into go-gitea:master Jul 3, 2019
@zeripath
Copy link
Contributor

zeripath commented Jul 3, 2019

Please send backport

@lunny lunny deleted the lunny/fix_hooks_routes branch July 3, 2019 05:34
lunny added a commit to lunny/gitea that referenced this pull request Jul 3, 2019
@lunny lunny mentioned this pull request Jul 3, 2019
@lunny lunny added the backport/done All backports for this PR have been created label Jul 3, 2019
techknowlogick pushed a commit that referenced this pull request Jul 3, 2019
@Cherrg
Copy link
Contributor

Cherrg commented Jul 4, 2019

i don't know why, but since merging this drone build seems to be broken

@techknowlogick
Copy link
Member

@Cherrg fail is due to an upstream dependency not related to this PR

@Cherrg
Copy link
Contributor

Cherrg commented Jul 4, 2019

ok, only looked what was merged before it was broken :)

unfortunately i cant reproduce this on my local machine to track down the error

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants