Skip to content

Fix database lock when use random repository fallback image #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2019
Merged

Fix database lock when use random repository fallback image #7166

merged 3 commits into from
Jun 12, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 10, 2019

No description provided.

@lunny lunny added the type/bug label Jun 10, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 10, 2019
@codecov-io
Copy link

codecov-io commented Jun 10, 2019 •
edited
Loading

Codecov Report

Merging #7166 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7166      +/-   ##
==========================================
+ Coverage   41.72%   41.72%   +<.01%     
==========================================
  Files         449      449              
  Lines       61130    61129       -1     
==========================================
  Hits        25509    25509              
+ Misses      32306    32305       -1     
  Partials     3315     3315
Impacted Files Coverage Δ
models/repo.go 48.44% <71.42%> (+0.08%) ⬆️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1608f63...6f4a30b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2019
@techknowlogick techknowlogick merged commit 5832f8d into go-gitea:master Jun 12, 2019
@lunny lunny deleted the lunny/fix_db_lock branch June 12, 2019 00:55
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Fix database lock when use random repository fallback image (go-gitea…
e669da8 
…#7166)

* fix database lock when use random repository fallback image

* remove unused function
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @zeripath @sapk @techknowlogick @GiteaBot