Skip to content

Fix documentation on Oauth2.Enable flag #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2019
Merged

Fix documentation on Oauth2.Enable flag #7011

merged 3 commits into from
May 22, 2019

Conversation

emonty
Copy link
Contributor

@emonty emonty commented May 21, 2019

The docs list this as ENABLED, but in the source code it's
ENABLE, meaning following the docs leads to confusion.

@emonty
Fix documentation on Oauth2.Enable flag
99aaa6d 
The docs list this as ENABLED, but in the source code it's
ENABLE, meaning following the docs leads to confusion.
@codecov-io
Copy link

codecov-io commented May 21, 2019 •
edited
Loading

Codecov Report

Merging #7011 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7011      +/-   ##
==========================================
+ Coverage   41.48%   41.48%   +<.01%     
==========================================
  Files         440      440              
  Lines       59453    59453              
==========================================
+ Hits        24663    24667       +4     
+ Misses      31570    31567       -3     
+ Partials     3220     3219       -1
Impacted Files Coverage Δ
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️
modules/log/log.go 71.42% <0%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d69dfb...7ae3b77. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2019
@techknowlogick
Copy link
Member

Can you update https://github.com/go-gitea/gitea/blob/master/custom/conf/app.ini.sample#L701 too?

@emonty
Copy link
Contributor Author

emonty commented May 21, 2019

@techknowlogick absolutely - good point.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2019
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label May 21, 2019
@techknowlogick techknowlogick merged commit 6eb53ac into go-gitea:master May 22, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@emonty @jeffliu27
Fix documentation on Oauth2.Enable flag (go-gitea#7011)
036c9de 
* Fix documentation on Oauth2.Enable flag

The docs list this as ENABLED, but in the source code it's
ENABLE, meaning following the docs leads to confusion.

* Update sample config for oauth2.ENABLE
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emonty @codecov-io @techknowlogick @lafriks @zeripath @GiteaBot