Skip to content

Conversation

ngourdon
Copy link
Contributor

fix #6777 and add tests for team API

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2019
@lafriks
Copy link
Member

lafriks commented Apr 27, 2019

Thanks for adding tests 👍 small nit but otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 27, 2019
@codecov-io
Copy link

codecov-io commented Apr 27, 2019

Codecov Report

Merging #6780 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6780      +/-   ##
==========================================
+ Coverage   40.99%   41.22%   +0.22%     
==========================================
  Files         421      421              
  Lines       58054    58054              
==========================================
+ Hits        23802    23933     +131     
+ Misses      31086    30954     -132     
- Partials     3166     3167       +1
Impacted Files Coverage Δ
routers/api/v1/org/team.go 25.58% <100%> (+21.59%) ⬆️
modules/log/router.go 90% <0%> (-2.5%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/api/v1/api.go 70.42% <0%> (+1.74%) ⬆️
models/org_team.go 53.24% <0%> (+2.86%) ⬆️
models/access.go 66.87% <0%> (+5.09%) ⬆️
models/unit.go 67.56% <0%> (+24.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81059a2...f347d91. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2019
@techknowlogick techknowlogick merged commit 4e31112 into go-gitea:master Apr 27, 2019
@techknowlogick
Copy link
Member

@ngourdon thanks for PR :) would you be able to backport this PR to the release/v1.8 branch?

@lafriks lafriks added backport/done All backports for this PR have been created modifies/api This PR adds API routes or modifies them labels Apr 28, 2019
@ngourdon ngourdon deleted the fix-6777 branch June 2, 2019 13:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit team API fails with nil pointer dereference
5 participants