Skip to content

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Apr 25, 2019

This includes API calls and git clones
(username is token and password is either empty or x-oauth-basic)

@jonasfranz If possible could you review as you have most knowledge of OAuth2 implementation.

oauth token can be used in basic auth
@codecov-io
Copy link

codecov-io commented Apr 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@199faad). Click here to learn what that means.
The diff coverage is 19.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6747   +/-   ##
=========================================
  Coverage          ?   41.02%           
=========================================
  Files             ?      421           
  Lines             ?    57955           
  Branches          ?        0           
=========================================
  Hits              ?    23777           
  Misses            ?    31022           
  Partials          ?     3156
Impacted Files Coverage Δ
routers/repo/http.go 38.07% <11.11%> (ø)
modules/auth/auth.go 49.23% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199faad...11fc783. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2019
@techknowlogick techknowlogick added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Apr 25, 2019
@Tchoupinax
Copy link
Contributor

Hello :)

This fix solves my problem ! (After migrating Gitea to 1.8 and Drone to 1.1.0). Thank you ! ;)

@techknowlogick techknowlogick removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Apr 25, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2019
@techknowlogick techknowlogick merged commit ec2d489 into go-gitea:master Apr 25, 2019
@techknowlogick techknowlogick deleted the git_clone_oauth branch April 25, 2019 22:42
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 25, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants