Skip to content

disable web preview for telegram webhook #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

disable web preview for telegram webhook #6683

wants to merge 4 commits into from

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Apr 19, 2019

Linked to #6682

@InExtremaRes
Copy link

I've tested and looks better now. Thank you.

What about the issue with the content of comments? As I commented in #6682 there is no line feed (or blank line) before the content of an issue or PR comment.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2019
@codecov-io
Copy link

codecov-io commented Apr 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b74dc97). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6683   +/-   ##
=========================================
  Coverage          ?   40.83%           
=========================================
  Files             ?      419           
  Lines             ?    57341           
  Branches          ?        0           
=========================================
  Hits              ?    23414           
  Misses            ?    30804           
  Partials          ?     3123
Impacted Files Coverage Δ
models/webhook_telegram.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74dc97...eea03e7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2019
@techknowlogick
Copy link
Member Author

@InExtremaRes I'm currently traveling right now so I can't get to adding in the line breaks, but if you want to attempt it the changes would be in same file as this PR (models/webhook_telegram.go).

@InExtremaRes
Copy link

@techknowlogick I don't have tools to edit Go nor experience with it 😢. But I think that piece is far less important than the one you've fixed. Nonetheless, I wouldn't mark #6682 as fixed (and closed) by this PR, or is it better to open a new issue for those?

@techknowlogick
Copy link
Member Author

@InExtremaRes that's ok. We appreciate the bug reports as well, without them there might be something that is broken which affects users that wouldn't be fixed because we wouldn't know.

I've edited my PR so it won't closed the linked ticket, but maybe once this is merged I'll update linked ticket to be just about the line breaks.

@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch April 21, 2019 03:01
@InExtremaRes
Copy link

Hi @techknowlogick. Why was this closed?

@techknowlogick
Copy link
Member Author

@InExtremaRes ack. Seems I deleted this branch during a regularly planned cleanup of my fork (I usually do them after a major release) and I got this one. I’ll relish the branch and open a PR again for it. Thanks for catching this :)

@techknowlogick techknowlogick removed this from the 1.9.0 milestone Apr 23, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants