-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
disable web preview for telegram webhook #6683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable web preview for telegram webhook #6683
Conversation
I've tested and looks better now. Thank you. What about the issue with the content of comments? As I commented in #6682 there is no line feed (or blank line) before the content of an issue or PR comment. |
Codecov Report
@@ Coverage Diff @@
## master #6683 +/- ##
=========================================
Coverage ? 40.83%
=========================================
Files ? 419
Lines ? 57341
Branches ? 0
=========================================
Hits ? 23414
Misses ? 30804
Partials ? 3123
Continue to review full report at Codecov.
|
@InExtremaRes I'm currently traveling right now so I can't get to adding in the line breaks, but if you want to attempt it the changes would be in same file as this PR ( |
@techknowlogick I don't have tools to edit Go nor experience with it 😢. But I think that piece is far less important than the one you've fixed. Nonetheless, I wouldn't mark #6682 as fixed (and closed) by this PR, or is it better to open a new issue for those? |
@InExtremaRes that's ok. We appreciate the bug reports as well, without them there might be something that is broken which affects users that wouldn't be fixed because we wouldn't know. I've edited my PR so it won't closed the linked ticket, but maybe once this is merged I'll update linked ticket to be just about the line breaks. |
Hi @techknowlogick. Why was this closed? |
@InExtremaRes ack. Seems I deleted this branch during a regularly planned cleanup of my fork (I usually do them after a major release) and I got this one. I’ll relish the branch and open a PR again for it. Thanks for catching this :) |
Linked to #6682