Skip to content

Fix ambiguity bug in getCommentsByRepoIDSince #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2017
Merged

Fix ambiguity bug in getCommentsByRepoIDSince #665

merged 1 commit into from
Jan 14, 2017

Conversation

ethantkoenig
Copy link
Member

In getCommentsByRepoIDSince, there's are join of the issue and comment tables, both of which have created_unix and updated_unix columns. See issue #663.

@ethantkoenig ethantkoenig mentioned this pull request Jan 13, 2017
Closed
6 tasks
@lunny
Copy link
Member

lunny commented Jan 14, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 14, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 14, 2017
@lunny lunny added the type/bug label Jan 14, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2017
@lunny lunny merged commit a6f5efa into go-gitea:master Jan 14, 2017
@ethantkoenig ethantkoenig deleted the fix/comments branch January 22, 2017 17:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethantkoenig @lunny @appleboy @tboerger