Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 1, 2019

should fix #6480

@lunny lunny added the type/bug label Apr 1, 2019
@lunny lunny added this to the 1.9.0 milestone Apr 1, 2019
@codecov-io
Copy link

codecov-io commented Apr 1, 2019

Codecov Report

Merging #6482 into master will increase coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6482      +/-   ##
==========================================
+ Coverage   39.39%   39.41%   +0.01%     
==========================================
  Files         393      393              
  Lines       53271    53269       -2     
==========================================
+ Hits        20988    20996       +8     
+ Misses      29297    29288       -9     
+ Partials     2986     2985       -1
Impacted Files Coverage Δ
routers/routes/routes.go 83.44% <100%> (ø) ⬆️
models/login_source.go 26.98% <50%> (+0.66%) ⬆️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04a1d9...feaa311. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 1, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 1, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2019
@lafriks
Copy link
Member

lafriks commented Apr 2, 2019

@lunny I backported as I needed this fix out to 1.8 branch asap :)

@lunny lunny deleted the lunny/fix_resend_confirm branch April 2, 2019 05:54
@lunny
Copy link
Member Author

lunny commented Apr 2, 2019

Thanks! @lafriks

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to request for second activation email
5 participants