Skip to content

Fix headline #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2019
Merged

Fix headline #6353

merged 2 commits into from
Mar 18, 2019

Conversation

SuperSandro2000
Copy link
Contributor

Hopefully fixes the incorrect rendered headline here https://docs.gitea.io/en-us/https-setup/

@codecov-io
Copy link

Codecov Report

Merging #6353 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6353      +/-   ##
==========================================
- Coverage   38.89%   38.88%   -0.01%     
==========================================
  Files         363      363              
  Lines       51210    51210              
==========================================
- Hits        19917    19912       -5     
- Misses      28425    28430       +5     
  Partials     2868     2868
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8cdbd...5003abb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2019
@SuperSandro2000
Copy link
Contributor Author

How does that commit change file coverage? I don't quite understand that.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2019
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Mar 18, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2019
@lunny
Copy link
Member

lunny commented Mar 18, 2019

@SuperSandro2000 the coverage bot don't really know what the PR doing.

@techknowlogick
Copy link
Member

make LG-TM work

@techknowlogick techknowlogick merged commit c151682 into go-gitea:master Mar 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuperSandro2000 @codecov-io @lunny @techknowlogick @GiteaBot