Expose issue stopwatch toggling via API #5970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelowo
force-pushed
the
expose_time_tracking_as_api
branch
from
4fc3634 to
488c40c
Compare
adelowo
commented
Feb 5, 2019
GiteaBot
added
the
lgtm/need 2
adelowo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5970 +/- ##
=========================================
- Coverage 38.8% 38.71% -0.1%
=========================================
Files 330 330
Lines 48731 48853 +122
=========================================
+ Hits 18911 18912 +1
- Misses 27081 27201 +120
- Partials 2739 2740 +1
Continue to review full report at Codecov.
|
lafriks
requested changes
Feb 5, 2019
Member
lafriks
left a comment
lafriks
left a comment
There was a problem hiding this comment.
I don't actually like toggle method as you are kind of guessing state... I would prefer if API had start & stop methods
adelowo
force-pushed
the
expose_time_tracking_as_api
branch
from
488c40c to
2f9fb24
Compare
Member
Author
|
Done @lafriks. |
lafriks
requested changes
Feb 6, 2019
lafriks
approved these changes
Feb 6, 2019
GiteaBot
added
lgtm/need 1
lafriks
added
the
type/feature
techknowlogick
approved these changes
Feb 7, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. #4327 automatically stops the stopwatch but this PR will be useful in case there
is a need to programmatically toggle the stopwatch.
Fixes #5942