Skip to content

Improve the performance of tree listing #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Improve the performance of tree listing #570

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79cfbe8
Preliminary implementation
typeless Jan 3, 2017
0088b59
Do not redundantly sort the tree entries
typeless Jan 3, 2017
791d3e4
Use ctx.QueryInt("start") and ctx.QueryInt("count")
typeless Jan 3, 2017
1fe0d48
Check invalid query values
typeless Jan 6, 2017
702565e
Should check if the values are not provided (start=0 count=0)
typeless Jan 6, 2017
0c6d9ce
Revert the change of removing entries sorting
typeless Jan 7, 2017
f155fc1
Remove redundant empty lines
typeless Jan 7, 2017
7594d24
Reduce the condition formula of input validation
typeless Jan 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions routers/repo/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ package repo

import (
"bytes"
"encoding/base64"
"fmt"
gotemplate "html/template"
"io/ioutil"
"path"
"strconv"
"strings"

"code.gitea.io/git"
Expand All @@ -22,9 +24,7 @@ import (
"code.gitea.io/gitea/modules/markdown"
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/templates"
"encoding/base64"
"github.com/Unknwon/paginater"
"strconv"
)

const (
Expand All @@ -45,8 +45,19 @@ func renderDirectory(ctx *context.Context, treeLink string) {
ctx.Handle(500, "ListEntries", err)
return
}

entries.Sort()

start := ctx.QueryInt("start")
count := ctx.QueryInt("count")

// Check invalid values
if (start == 0 && count == 0) || count < 0 || start+count > len(entries) {
start = 0
count = len(entries)
}
entries = entries[start : start+count]

ctx.Data["Files"], err = entries.GetCommitsInfo(ctx.Repo.Commit, ctx.Repo.TreePath)
if err != nil {
ctx.Handle(500, "GetCommitsInfo", err)
Expand Down