SECURITY: prevent DeleteFilePost doing arbitrary deletion #5631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5631 +/- ##
=========================================
Coverage ? 37.81%
=========================================
Files ? 322
Lines ? 47485
Branches ? 0
=========================================
Hits ? 17957
Misses ? 26939
Partials ? 2589
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
jonasfranz
added
topic/security
|
@go-gitea/owners I think we have to backport this to 1.6 since this is quite critical IMHO. |
jonasfranz
suggested changes
Jan 4, 2019
This commit wraps more of the TreePaths with cleanUploadFileName Signed-off-by: Andrew Thornton <[email protected]>
zeripath
force-pushed
the
protect-delete-file
branch
from
9663346 to
d87fcfc
Compare
jonasfranz
approved these changes
Jan 4, 2019
bkcsoft
added
lgtm/need 1
techknowlogick
approved these changes
Jan 4, 2019
bkcsoft
added
lgtm/done
|
@zeripath thanks for PR :) as @jonasfranz has said, please backport to both release/v1.7 and release/v1.6 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 4, 2019
…itea#5631) This commit wraps more of the TreePaths with cleanUploadFileName Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 4, 2019
…itea#5631) This commit wraps more of the TreePaths with cleanUploadFileName Signed-off-by: Andrew Thornton <[email protected]>
jonasfranz
pushed a commit
that referenced
this pull request
Jan 4, 2019
… (#5634) This commit wraps more of the TreePaths with cleanUploadFileName Signed-off-by: Andrew Thornton <[email protected]>
jonasfranz
pushed a commit
that referenced
this pull request
Jan 4, 2019
… (#5635) This commit wraps more of the TreePaths with cleanUploadFileName Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately a suitably malformed request to DeleteFilePost will allow arbitrary deletion. Further it was also possible to adjust the .git directories on editFilePost and UploadFilePost.